Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a new state to SSLClientSocket Connect, fixed various comment issues. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 3a8b39e678c2785ea4d6fd7c60fea762fb599883..855efa81b68e493b0dfe3da2098e730ced8cd610 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -2881,6 +2881,21 @@ bool SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {
return true;
}
+bool SSLClientSocketNSS::InSessionCache() const {
+ // For now, always return true so that SSLConnectJobs are never held back.
+ return true;
+}
+
+void SSLClientSocketNSS::SetHandshakeSuccessCallback(
+ const base::Closure& callback) {
+ NOTIMPLEMENTED();
+}
+
+void SSLClientSocketNSS::SetHandshakeFailureCallback(
+ const base::Closure& callback) {
+ NOTIMPLEMENTED();
+}
Ryan Sleevi 2014/07/25 01:36:36 Out of date.
mshelley 2014/07/26 00:58:27 Done.
+
void SSLClientSocketNSS::GetSSLCertRequestInfo(
SSLCertRequestInfo* cert_request_info) {
EnterFunction("");

Powered by Google App Engine
This is Rietveld 408576698