net/http/http_network_session.cc - Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_session.cc

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a new state to SSLClientSocket Connect, fixed various comment issues. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_session.cc

diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc

index 5fc60701e143cfd77b8b2fbc494c60b769a58295..6d718ffd4e457cb34f1b1f809d98a867fe3417fe 100644

--- a/net/http/http_network_session.cc

+++ b/net/http/http_network_session.cc

@@ -36,9 +36,9 @@ net::ClientSocketPoolManager* CreateSocketPoolManager(

// simultaneous connections for WebSockets.

return new net::ClientSocketPoolManagerImpl(

params.net_log,

- params.client_socket_factory ?

- params.client_socket_factory :

- net::ClientSocketFactory::GetDefaultFactory(),

+ params.client_socket_factory

+ ? params.client_socket_factory

+ : net::ClientSocketFactory::GetDefaultFactory(),

params.host_resolver,

params.cert_verifier,

params.server_bound_cert_service,

@@ -47,6 +47,7 @@ net::ClientSocketPoolManager* CreateSocketPoolManager(

params.ssl_session_cache_shard,

params.proxy_service,

params.ssl_config_service,

+ params.enable_ssl_connect_job_waiting,

pool_type);

}

« no previous file with comments | « net/http/http_network_session.h ('k') | net/http/http_network_transaction_unittest.cc » ('j') | net/socket/socket_test_util.h » ('J')