Implements new, more robust design for communicating between SSLConnectJobs.

net/socket/ssl_client_socket.h

Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index a43e58cc26b852fb86d92a1a5ac7c4e7c357b286..d03746e563fec47cbee3daa78783dc39eb49e951 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -9,6 +9,7 @@
 
 #include "base/gtest_prod_util.h"
 #include "net/base/completion_callback.h"
+#include "net/base/host_port_pair.h"

[wtc, 2014/07/18 01:17:14]

A forward declaration of class HostPortPair should be sufficient.

[mshelley, 2014/07/18 21:08:31]

Done.

 #include "net/base/load_flags.h"
 #include "net/base/net_errors.h"
 #include "net/socket/ssl_socket.h"
@@ -81,6 +82,30 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
   virtual bool WasNpnNegotiated() const OVERRIDE;
   virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
 
+  // Formats a unique key for the SSL session cache. This method
+  // is necessary so that all classes create cache keys in a consistent
+  // manner.
+  // TODO(mshelley) This method will be deleted soon.
+  static std::string GetSessionCacheKey(
+      const HostPortPair& host_and_port,
+      const std::string& ssl_session_cache_shard);
+
+  // Returns true if there is a cache entry in the SSL session cache
+  // for the cache key of the SSL socket.
+  //
+  // The cache key consists of a host and port concatenated with a session
+  // cache shard. These two strings are passed to the constructor of most
+  // subclasses of SSLClientSocket.
+  virtual bool InSessionCache() const = 0;
+
+  // Tells the session cache to monitor this socket's session and inform
+  // its SSLConnectJobMessenger upon the sessions being made available for

[wtc, 2014/07/18 01:17:14]

inform its SSLConnectJobMessenger => runs the callback

sessions => session

[mshelley, 2014/07/18 21:08:31]

Done.

+  // resumption.
+  virtual void SetHandshakeSuccessCallback(const base::Closure& callback) = 0;
+
+  // Sets the callback to be used if the socket's SSL handshake should fail.
+  virtual void SetHandshakeFailureCallback(const base::Closure& callback) = 0;
+
   // Gets the SSL CertificateRequest info of the socket after Connect failed
   // with ERR_SSL_CLIENT_AUTH_CERT_NEEDED.
   virtual void GetSSLCertRequestInfo(