Implements new, more robust design for communicating between SSLConnectJobs.

net/socket/ssl_client_socket.h

Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index a43e58cc26b852fb86d92a1a5ac7c4e7c357b286..b4cb39a608c507c4af1f93011a2f44d8b9dcd561 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -81,6 +81,30 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
   virtual bool WasNpnNegotiated() const OVERRIDE;
   virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
 
+  // Formats a unique key for the SSL session cache. This method
+  // is necessary so that all classes create cache keys in a consistent
+  // manner.
+  // TODO(mshelley) this method will be deleted soon.

[mmenke, 2014/07/17 19:21:31]

nit:  When comments are complete sentences (Which most should be), capitalize
(And end with a period, like you're already doing).

[mshelley, 2014/07/17 21:12:48]

Done.

+  static std::string FormatSessionCacheKey(

[mmenke, 2014/07/17 19:21:31]

nit:  Suggest calling this GetSessionCacheKey - think that's more consistent
with naming used elsewhere in the network stack.

[mshelley, 2014/07/17 21:12:48]

Done.

+      const std::string& host_and_port,

[mmenke, 2014/07/17 19:21:31]

Suggest just taking a const HostPortPair& here, instead, since that's what all
callers have to work with, anyways.  May need to forward declare HostPortPair in
this file.

[mshelley, 2014/07/17 21:12:48]

Done.

+      const std::string& ssl_session_cache_shard);
+
+  // Returns true if there is a cache entry in the ssl session cache
+  // for the cache key of the SSL socket.

[mmenke, 2014/07/17 19:21:31]

nit:  Should use consistent capitalization of SSL.

[mshelley, 2014/07/17 21:12:48]

Done.

+  //
+  // The cache key consists of a host and port concatenated with a session
+  // cache shard. These two strings are passed to the constructor of most
+  // subclasses of SSLClientSocket.
+  virtual bool InSessionCache() const = 0;
+
+  // Tells the session cache to monitor this socket's session and inform
+  // its SSLConnectJobMessenger upon the sessions being made available for
+  // resumption.
+  virtual void SetHandshakeSuccessCallback(const base::Closure& callback) = 0;
+
+  // Sets the callback to be used if the socket's ssl handshake should fail.

[mmenke, 2014/07/17 19:21:31]

nit:  Should use consistent capitalization of SSL.

[mshelley, 2014/07/17 21:12:48]

Done.

+  virtual void SetHandshakeFailureCallback(const base::Closure& callback) = 0;
+
   // Gets the SSL CertificateRequest info of the socket after Connect failed
   // with ERR_SSL_CLIENT_AUTH_CERT_NEEDED.
   virtual void GetSSLCertRequestInfo(