Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed the structure of pending_sockets_and_callbacks_ and made cl compatible with nss. (Fixed one… Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 3a8b39e678c2785ea4d6fd7c60fea762fb599883..db1b2b2477e9a92668b874113e83a359306c7585 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -2881,6 +2881,29 @@ bool SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {
return true;
}
+bool SSLClientSocketNSS::InSessionCache() const {
+ // For now, always return true so that SSLConnectJobs are never held back.
+ return true;
+}
+
+void SSLClientSocketNSS::WatchSessionForCompletion(
+ const base::Closure& callback) {
+ NOTREACHED();
+}
+
+void SSLClientSocketNSS::SetSocketFailureCallback(
+ const base::Closure& callback) {
+ NOTREACHED();
+}
+
+void SSLClientSocketNSS::SetIsLeader() {
+ NOTREACHED();
+}
+
+void SSLClientSocketNSS::OnSocketFailure() {
+ NOTREACHED();
+}
+
void SSLClientSocketNSS::GetSSLCertRequestInfo(
SSLCertRequestInfo* cert_request_info) {
EnterFunction("");

Powered by Google App Engine
This is Rietveld 408576698