Implements new, more robust design for communicating between SSLConnectJobs.

net/socket/ssl_session_cache_openssl.h

Index: net/socket/ssl_session_cache_openssl.h
diff --git a/net/socket/ssl_session_cache_openssl.h b/net/socket/ssl_session_cache_openssl.h
index bbd9659641df062dc870880f805031006deddb59..14500684a76e54d63bf7e2940b0fdb974357667c 100644
--- a/net/socket/ssl_session_cache_openssl.h
+++ b/net/socket/ssl_session_cache_openssl.h
@@ -8,7 +8,9 @@
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"

[wtc, 2014/06/27 00:36:50]

You should not need to include scoped_ptr.h because scoped_ptr is not used in
this file.

[mshelley, 2014/07/01 02:35:23]

Done.

 #include "net/base/net_export.h"
+#include "net/socket/ssl_client_socket_openssl.h"

[wtc, 2014/06/27 00:36:50]

You should not need to include this header.

[mshelley, 2014/07/01 02:35:23]

Done.

 
 // Avoid including OpenSSL headers here.
 typedef struct ssl_ctx_st SSL_CTX;
@@ -113,6 +115,13 @@ class NET_EXPORT SSLSessionCacheOpenSSL {
   // Return true iff a cached session was associated with the |ssl| connection.
   bool SetSSLSessionWithKey(SSL* ssl, const std::string& cache_key);
 
+  // Return true iff a cached session was associated with the given |cache_key|.
+  bool SSLSessionIsInCache(const std::string& cache_key) const;
+
+  // Informs the cache that it should notify the messenger when |socket|'s

[wtc, 2014/06/27 00:36:50]

1. notify the messenger => run the callback |cb|

2. |socket| is not a parameter of this function. Perhaps you meant |ssl|?

[mshelley, 2014/07/01 02:35:23]

Done.

+  // session is added to the cache.
+  void NotifyOnSessionAdded(SSL* ssl, const base::Closure& cb);

[wtc, 2014/06/27 00:36:50]

cb => callback or closure ?

Our Style Guide recommends against using abbreviations for variable/parameter
names in general.

[mshelley, 2014/07/01 02:35:23]

Done.

+
   // Indicates that the SSL session associated with |ssl| is "good" - that is,
   // that all associated cryptographic parameters that were negotiated,
   // including the peer's certificate, were successfully validated. Because