Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 353713005: Implements new, more robust design for communicating between SSLConnectJobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implements new, more robust design for communicating between SSLConectJobs. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index 4ff8d438e965b1fdf0b5b7f8b4ecdb75e1d14d66..cb2dc4b10b6148ddb966001cb0b9673ed0aebedc 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -366,6 +366,21 @@ SSLClientSocketOpenSSL::~SSLClientSocketOpenSSL() {
Disconnect();
}
+bool SSLClientSocketOpenSSL::InSessionCache() const {
+ SSLContext* context = SSLContext::GetInstance();
+ std::string cache_key = GetSocketSessionCacheKey(*this);
+ return context->session_cache()->SSLSessionIsInCache(cache_key);
+}
+
+void SSLClientSocketOpenSSL::OnSessionComplete(const base::Closure& cb) const {
+ SSLContext* context = SSLContext::GetInstance();
+ context->session_cache()->NotifyOnSessionAdded(ssl_, cb);
+}
+
+void SSLClientSocketOpenSSL::OnSocketFailure(const base::Closure& cb) {
+ error_callback_ = cb;
wtc 2014/06/27 00:36:49 IMPORTANT: the error_callback_ member is not being
mshelley 2014/07/01 02:35:22 Done.
+}
+
void SSLClientSocketOpenSSL::GetSSLCertRequestInfo(
SSLCertRequestInfo* cert_request_info) {
cert_request_info->host_and_port = host_and_port_;

Powered by Google App Engine
This is Rietveld 408576698