Implements new, more robust design for communicating between SSLConnectJobs.

net/socket/ssl_session_cache_openssl.h

Index: net/socket/ssl_session_cache_openssl.h
diff --git a/net/socket/ssl_session_cache_openssl.h b/net/socket/ssl_session_cache_openssl.h
index bbd9659641df062dc870880f805031006deddb59..df065cbaadf5511e5571a93fbf35dd65552b7931 100644
--- a/net/socket/ssl_session_cache_openssl.h
+++ b/net/socket/ssl_session_cache_openssl.h
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/callback.h"

[wtc, 2014/07/08 01:25:43]

Include base/callback_forward.h instead for the forward declaration of
base::Closure.

[mshelley, 2014/07/09 19:51:02]

I'm not positive, but I think that I do need to include base/callback.h in order
to call Run() on a Closure. I tried excluding it and got an incomplete type
error.

 #include "net/base/net_export.h"
 
 // Avoid including OpenSSL headers here.
@@ -113,6 +114,13 @@ class NET_EXPORT SSLSessionCacheOpenSSL {
   // Return true iff a cached session was associated with the |ssl| connection.
   bool SetSSLSessionWithKey(SSL* ssl, const std::string& cache_key);
 
+  // Return true iff a cached session was associated with the given |cache_key|.
+  bool SSLSessionIsInCache(const std::string& cache_key) const;
+
+  // Informs the cache that it should run the messenger's callback when |ssl|'s

[wtc, 2014/07/08 01:25:43]

Remove "messenger's". In this file, "messenger" isn't defined.

[mshelley, 2014/07/09 19:51:02]

Done.

+  // session is added to the cache.
+  void NotifyOnSessionAdded(SSL* ssl, const base::Closure& callback);
+
   // Indicates that the SSL session associated with |ssl| is "good" - that is,
   // that all associated cryptographic parameters that were negotiated,
   // including the peer's certificate, were successfully validated. Because