Implements new, more robust design for communicating between SSLConnectJobs.

net/socket/ssl_client_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 63 matching lines @@
     kNextProtoUnsupported = 0,  // The server doesn't support NPN.
     kNextProtoNegotiated = 1,   // We agreed on a protocol.
     kNextProtoNoOverlap = 2,    // No protocols in common. We requested
                                 // the first protocol in our list.
   };
 
   // StreamSocket:
   virtual bool WasNpnNegotiated() const OVERRIDE;
   virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
 
+  // Returns true if there is a cache entry in the ssl session cache
+  // for the given cache key.
+  //
+  // The cache key consists of a host_and_poart concatenated with a session

[wtc, 2014/06/27 00:36:49]

Typo: poart => port

[mshelley, 2014/07/01 02:35:22]

Done.

+  // cache shard.
+  virtual bool InSessionCache() const = 0;
+
+  virtual void OnSessionComplete(const base::Closure& c) const = 0;
+
+  virtual void OnSocketFailure(const base::Closure& cb) = 0;

[wtc, 2014/06/27 00:36:49]

1. Document these two methods.

2. Don't abbreviate the parameter names. They should be named 'callback' or
'closure'.

[mshelley, 2014/07/01 02:35:22]

Done.

+
   // Gets the SSL CertificateRequest info of the socket after Connect failed
   // with ERR_SSL_CLIENT_AUTH_CERT_NEEDED.
   virtual void GetSSLCertRequestInfo(
       SSLCertRequestInfo* cert_request_info) = 0;
 
   // Get the application level protocol that we negotiated with the server.
   // *proto is set to the resulting protocol (n.b. that the string may have
   // embedded NULs).
   //   kNextProtoUnsupported: *proto is cleared.
   //   kNextProtoNegotiated:  *proto is set to the negotiated protocol.
@@ skipping 84 matching lines @@
   // True if NPN successfully negotiated SPDY.
   bool was_spdy_negotiated_;
   // Protocol that we negotiated with the server.
   NextProto protocol_negotiated_;
   // True if a channel ID was sent.
   bool channel_id_sent_;
   // True if SCTs were received via a TLS extension.
   bool signed_cert_timestamps_received_;
   // True if a stapled OCSP response was received.
   bool stapled_ocsp_response_received_;
+
+  // Callback that is invoked when the connection encounters an error.
+  base::Closure error_callback_;

[wtc, 2014/06/27 00:36:49]

Delete this? SSLClientSocketOpenSSL has a same-named member.

[mshelley, 2014/07/01 02:35:22]

Done.

 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_H_