Implements new, more robust design for communicating between SSLConnectJobs.

net/spdy/spdy_test_util_common.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_test_util_common.h"
 
 #include <cstddef>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 603 matching lines @@
   virtual int Write(IOBuffer* buf, int buf_len,
                     const CompletionCallback& callback) OVERRIDE {
     return ERR_IO_PENDING;
   }
 
   // Return kProtoUnknown to use the pool's default protocol.
   virtual NextProto GetNegotiatedProtocol() const OVERRIDE {
     return kProtoUnknown;
   }
 
   // The functions below are not expected to be called.

[wtc, 2014/07/08 01:25:43]

Note this comment.

Therefore, the three new methods should be below this line only if they are not
expected to be called.

[mshelley, 2014/07/09 19:51:02]

Done.

 
   virtual int Connect(const CompletionCallback& callback) OVERRIDE {
     ADD_FAILURE();
     return ERR_UNEXPECTED;
   }
 
   virtual bool WasEverUsed() const OVERRIDE {
     ADD_FAILURE();
     return false;
   }
 
   virtual bool UsingTCPFastOpen() const OVERRIDE {
     ADD_FAILURE();
     return false;
   }
 
   virtual bool WasNpnNegotiated() const OVERRIDE {
     ADD_FAILURE();
     return false;
   }
 
   virtual bool GetSSLInfo(SSLInfo* ssl_info) OVERRIDE {
     ADD_FAILURE();
     return false;
   }
 
+  bool InSessionCache() const { return false; }
+
+  void OnSessionComplete(const base::Closure& cb) const { return; }
+
+  void OnSocketFailure(const base::Closure& cb) { return; }

[wtc, 2014/07/08 01:25:43]

Are you sure we need to add these three methods?

They don't match the new SSLClientSocket methods exactly. They are not declared
with "virtual" and "OVERRIDE".

[mshelley, 2014/07/09 19:51:02]

Done.

+
  private:
   int read_result_;
 };
 
 base::WeakPtr<SpdySession> CreateFakeSpdySessionHelper(
     SpdySessionPool* pool,
     const SpdySessionKey& key,
     Error expected_status) {
   EXPECT_NE(expected_status, ERR_IO_PENDING);
   EXPECT_FALSE(HasSpdySession(pool, key));
@@ skipping 577 matching lines @@
   }
 }
 
 void SpdyTestUtil::SetPriority(RequestPriority priority,
                                SpdySynStreamIR* ir) const {
   ir->set_priority(ConvertRequestPriorityToSpdyPriority(
       priority, spdy_version()));
 }
 
 }  // namespace net