Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 353653003: Remove IgnoreAttributesAndSetProperty and replace uses by DefineProperty (Closed)

Created:
6 years, 6 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove IgnoreAttributesAndSetProperty and replace uses by DefineProperty BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -49 lines) Patch
M src/messages.js View 1 chunk +2 lines, -3 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/v8natives.js View 1 chunk +6 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/runtime-gen/ignoreattributesandsetproperty.js View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL
6 years, 6 months ago (2014-06-24 14:48:06 UTC) #1
rossberg
6 years, 5 months ago (2014-06-27 09:50:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698