Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 353603003: Move PositionWithAffinity class to editing (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, blink-reviews-rendering, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rune+blink, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move PositionWithAffinity class to editing This patch moves PositionWithAffinity class to editing/ from dom/Position.h since it is "affinity" is editing concept rather than DOM concept. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177035

Patch Set 1 : 2014-06-24T04:57:07 #

Total comments: 4

Patch Set 2 : 2014-06-26T05:52:09 rebase for commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -29 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Position.h View 1 1 chunk +0 lines, -27 lines 0 comments Download
A Source/core/editing/PositionWithAffinity.h View 1 chunk +32 lines, -0 lines 0 comments Download
A Source/core/editing/PositionWithAffinity.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderBR.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
6 years, 6 months ago (2014-06-24 09:14:53 UTC) #1
yosin_UTC9
+tkent@, since yutak@ is OOO til Jun 30. Could you take look? Thanks in advance.
6 years, 6 months ago (2014-06-26 01:38:17 UTC) #2
tkent
https://codereview.chromium.org/353603003/diff/20001/Source/core/editing/PositionWithAffinity.cpp File Source/core/editing/PositionWithAffinity.cpp (right): https://codereview.chromium.org/353603003/diff/20001/Source/core/editing/PositionWithAffinity.cpp#newcode1 Source/core/editing/PositionWithAffinity.cpp:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 6 months ago (2014-06-26 01:50:01 UTC) #3
yosin_UTC9
https://codereview.chromium.org/353603003/diff/20001/Source/core/editing/PositionWithAffinity.h File Source/core/editing/PositionWithAffinity.h (right): https://codereview.chromium.org/353603003/diff/20001/Source/core/editing/PositionWithAffinity.h#newcode1 Source/core/editing/PositionWithAffinity.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 6 months ago (2014-06-26 03:37:20 UTC) #4
tkent
https://codereview.chromium.org/353603003/diff/20001/Source/core/editing/PositionWithAffinity.h File Source/core/editing/PositionWithAffinity.h (right): https://codereview.chromium.org/353603003/diff/20001/Source/core/editing/PositionWithAffinity.h#newcode1 Source/core/editing/PositionWithAffinity.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 6 months ago (2014-06-26 03:46:20 UTC) #5
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-26 04:46:49 UTC) #6
yosin_UTC9
The CQ bit was unchecked by yosin@chromium.org
6 years, 6 months ago (2014-06-26 04:46:52 UTC) #7
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-26 04:47:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/353603003/20001
6 years, 6 months ago (2014-06-26 04:48:30 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-26 05:36:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 05:39:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8564)
6 years, 6 months ago (2014-06-26 05:39:18 UTC) #12
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-26 08:54:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/353603003/40001
6 years, 6 months ago (2014-06-26 08:55:15 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 01:23:35 UTC) #15
Message was sent while issue was closed.
Change committed as 177035

Powered by Google App Engine
This is Rietveld 408576698