Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: src/IceOperand.h

Issue 353553004: Add support for vector types and vector constants. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Patch Set: Print out types in error messages. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceOperand.h
diff --git a/src/IceOperand.h b/src/IceOperand.h
index 00febc402327a24773d41be5e7c6cebc4cbb2b6b..018445a60bbc197b12091e4a59edc82fb1f8ff07 100644
--- a/src/IceOperand.h
+++ b/src/IceOperand.h
@@ -120,10 +120,9 @@ public:
}
T getValue() const { return Value; }
using Constant::emit;
- virtual void emit(GlobalContext *Ctx) const {
- Ostream &Str = Ctx->getStrEmit();
- Str << getValue();
- }
+ // The target needs to implement this for each ConstantPrimitive
+ // specialization.
+ virtual void emit(GlobalContext *Ctx) const;
using Constant::dump;
virtual void dump(GlobalContext *Ctx) const {
Ostream &Str = Ctx->getStrDump();

Powered by Google App Engine
This is Rietveld 408576698