src/IceGlobalContext.cpp - Issue 353553004: Add support for vector types and vector constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalContext.cpp

Issue 353553004: Add support for vector types and vector constants. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Add a TODO about return values of vector type. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceGlobalContext.cpp

diff --git a/src/IceGlobalContext.cpp b/src/IceGlobalContext.cpp

index 7e89a41dad133960ff7cacc24735b61fc25f6e28..4534a04c2f3ed7e56ae5ed1faab438ae512dfd66 100644

--- a/src/IceGlobalContext.cpp

+++ b/src/IceGlobalContext.cpp

@@ -232,6 +232,14 @@ Constant *GlobalContext::getConstantZero(Type Ty) {

return getConstantFloat(0);

case IceType_f64:

return getConstantDouble(0);

+ case IceType_v4i1:

+ case IceType_v8i1:

+ case IceType_v16i1:

+ case IceType_v16i8:

+ case IceType_v8i16:

+ case IceType_v4i32:

+ case IceType_v4f32:

+ llvm_unreachable("Unsupported type");

Jim Stichnoth 2014/07/07 17:47:23 Add the type name to the error message (here and b

wala 2014/07/07 21:33:41 Done.

case IceType_void:

case IceType_NUM:

break;

@@ -251,6 +259,14 @@ ConstantList GlobalContext::getConstantPool(Type Ty) const {

return ConstPool->Floats.getConstantPool();