src/IceDefs.h - Issue 353553004: Add support for vector types and vector constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceDefs.h

Issue 353553004: Add support for vector types and vector constants. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: 1) Remove StringList. 2) Assign redundant assign TODO to stichnot. 3) Fix RUN line. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceDefs.h

diff --git a/src/IceDefs.h b/src/IceDefs.h

index 4c616f832bb68c19cb67412c91483c6a91c297a4..94b25a89b1bfaecea9f0a66d710e65521b9d2f2a 100644

--- a/src/IceDefs.h

+++ b/src/IceDefs.h

@@ -29,6 +29,7 @@

#include "llvm/ADT/BitVector.h"

#include "llvm/ADT/SmallBitVector.h"

+#include "llvm/ADT/SmallVector.h"

#include "llvm/ADT/STLExtras.h"

#include "llvm/Support/Casting.h"

#include "llvm/Support/Compiler.h" // LLVM_STATIC_ASSERT

@@ -65,6 +66,11 @@ typedef std::vector<Variable *> VarList;

typedef std::vector<CfgNode *> NodeList;

typedef std::vector<Constant *> ConstantList;

+const unsigned VECT128_BYTES = 16;

+// TODO(stichnot): Switch Vect128 to std::array after C++11

+typedef llvm::SmallVector<char, VECT128_BYTES> Vect128;

JF 2014/06/30 17:48:50 You should use uint8_t here. I'd also name the cla

wala 2014/06/30 22:13:24 Unless vector constants are supported, this type i

+typedef llvm::SmallVector<bool, VECT128_BYTES> BitVect;

JF 2014/06/30 17:48:50 Can you add a comment that explains this type?

wala 2014/06/30 22:13:24 Unless vector constants are supported, this type i

// SizeT is for holding small-ish limits like number of source

// operands in an instruction. It is used instead of size_t (which

// may be 64-bits wide) when we want to save space.

« no previous file with comments | « no previous file | src/IceGlobalContext.h » ('j') | src/IceGlobalContext.cpp » ('J')