runtime/vm/object_test.cc - Issue 353513002: Use range information for optimizing integer boxing and fix bug in range analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_test.cc

Issue 353513002: Use range information for optimizing integer boxing and fix bug in range analysis. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object_test.cc

===================================================================

--- runtime/vm/object_test.cc (revision 37654)

+++ runtime/vm/object_test.cc (working copy)

@@ -285,15 +285,18 @@

EXPECT(Smi::IsValid(0));

EXPECT(Smi::IsValid(-15));

+ EXPECT(Smi::IsValid(0xFFu));

// Upper two bits must be either 00 or 11.

#if defined(ARCH_IS_64_BIT)

EXPECT(!Smi::IsValid(kMaxInt64));

EXPECT(Smi::IsValid(0x3FFFFFFFFFFFFFFF));

- EXPECT(Smi::IsValid(0xFFFFFFFFFFFFFFFF));

+ EXPECT(Smi::IsValid(-1));

+ EXPECT(!Smi::IsValid(0xFFFFFFFFFFFFFFFFu));

#else

EXPECT(!Smi::IsValid(kMaxInt32));

EXPECT(Smi::IsValid(0x3FFFFFFF));

- EXPECT(Smi::IsValid(0xFFFFFFFF));

+ EXPECT(Smi::IsValid(-1));

+ EXPECT(!Smi::IsValid(0xFFFFFFFFu));

#endif

EXPECT_EQ(5, smi.AsInt64Value());

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »