runtime/vm/dart_api_impl.cc - Issue 353513002: Use range information for optimizing integer boxing and fix bug in range analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 353513002: Use range information for optimizing integer boxing and fix bug in range analysis. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 37654)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -1974,7 +1974,7 @@

// Fast path for Smis.

Isolate* isolate = Isolate::Current();

CHECK_ISOLATE(isolate);

- if (Smi::IsValid64(value)) {

+ if (Smi::IsValid(value)) {

NOHANDLESCOPE(isolate);

return Api::NewHandle(isolate, Smi::New(static_cast<intptr_t>(value)));

}

@@ -4699,7 +4699,7 @@

int64_t retval) {

NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);

ASSERT(arguments->isolate() == Isolate::Current());

- if (Smi::IsValid64(retval)) {

+ if (Smi::IsValid(retval)) {

Api::SetSmiReturnValue(arguments, retval);

} else {

// Slow path for Mints and Bigints.

« no previous file with comments | « runtime/lib/integers.cc ('k') | runtime/vm/dart_api_message.cc » ('j') | no next file with comments »