Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: runtime/vm/object_test.cc

Issue 353403004: Fixes Android build by using C++ math header instead of C one. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 37827)
+++ runtime/vm/object_test.cc (working copy)
@@ -2,7 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// TODO(zra): Remove when tests are ready to enable.
#include "platform/globals.h"
#include "vm/assembler.h"
@@ -527,7 +526,7 @@
EXPECT(!dbl1.OperatorEquals(Smi::Handle(Smi::New(3))));
EXPECT(!dbl1.OperatorEquals(Double::Handle()));
const Double& nan0 = Double::Handle(Double::New(NAN));
- EXPECT(isnan(nan0.value()));
+ EXPECT(std::isnan(nan0.value()));
EXPECT(nan0.IsIdenticalTo(nan0));
EXPECT(nan0.CanonicalizeEquals(nan0));
EXPECT(!nan0.OperatorEquals(nan0));
@@ -535,8 +534,8 @@
Double::New(bit_cast<double>(kMaxUint64 - 0)));
const Double& nan2 = Double::Handle(
Double::New(bit_cast<double>(kMaxUint64 - 1)));
- EXPECT(isnan(nan1.value()));
- EXPECT(isnan(nan2.value()));
+ EXPECT(std::isnan(nan1.value()));
+ EXPECT(std::isnan(nan2.value()));
EXPECT(!nan1.IsIdenticalTo(nan2));
EXPECT(!nan1.CanonicalizeEquals(nan2));
EXPECT(!nan1.OperatorEquals(nan2));
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | runtime/vm/simulator_arm64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698