Fixes Android build by using C++ math header instead of C one.

Fixes Android build by using C++ math header instead of C one.

This change also requires prefacing the math calls with
std::, i.e. isinf -> std::isinf.

R=asiva@google.com, koda@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37839

[koda, 2014-06-30 20:50:40]

lgtm, thanks for doing this!

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm64.cc:2446: if (std::isinf(a) || (fabs(a) >=
exp2f(126))) return 0.0;
It looks slightly odd to have only one of these in std:: (since we still use
float.h rather than cfloat), but I think that's acceptable.

[siva, 2014-06-30 20:59:34]

lgtm

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm64.cc:2446: if (std::isinf(a) || (fabs(a) >=
exp2f(126))) return 0.0;
On 2014/06/30 20:50:40, koda wrote:
> It looks slightly odd to have only one of these in std:: (since we still use
> float.h rather than cfloat), but I think that's acceptable.

I agree too, it does seem odd.

I am wondering if it would be more readable to add a 'vm/math.h' file and in it
have:
#include <cmath>
#define isinf(val) std:isinf(val)
#define isnan(val) std::isnan(val)

[zra, 2014-06-30 20:59:45]

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm64.cc:2446: if (std::isinf(a) || (fabs(a) >=
exp2f(126))) return 0.0;
On 2014/06/30 20:50:40, koda wrote:
> It looks slightly odd to have only one of these in std:: (since we still use
> float.h rather than cfloat), but I think that's acceptable.

Yah, it does look strange, but hopefully it will mean less work when we pull the
STL out.

[zra, 2014-06-30 22:14:34]

Put the #define's in platform/math.h to include from platform/globals.h.

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/353403004/diff/40001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm64.cc:2446: if (std::isinf(a) || (fabs(a) >=
exp2f(126))) return 0.0;
On 2014/06/30 20:59:34, siva wrote:
> On 2014/06/30 20:50:40, koda wrote:
> > It looks slightly odd to have only one of these in std:: (since we still use
> > float.h rather than cfloat), but I think that's acceptable.
> 
> I agree too, it does seem odd.
> 
> I am wondering if it would be more readable to add a 'vm/math.h' file and in
it
> have:
> #include <cmath>
> #define isinf(val) std:isinf(val)
> #define isnan(val) std::isnan(val)

Done.

[zra, 2014-06-30 22:15:35]

Committed patchset #8 manually as r37839 (presubmit successful).