DevTools: DataGrid: remove duplicated implementaion of nodes sorting.

DevTools: DataGrid: remove duplicated implementaion of nodes sorting.

BUG=316092
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177380

[alph, 2014-06-30 12:36:55]

lgtm

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/DataGrid.js (right):

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/DataGrid.js:166:
WebInspector.DataGrid.TrivialComparator = function(a, b)
Perhaps it's worth to drop this thing and just have a dummy function in the
DirectoryContentView.

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/DataGrid.js:181: var aNumber = Number(aValue
instanceof Node ? aValue.textContent : aValue);
It would be nice to have the instanceof check done once when the comparator is
created

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/DataGrid.js:831: this._sortingFunction =
sortingFunction;
Can't see where that one is used.

[eustas, 2014-06-30 16:33:31]

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/DataGrid.js (right):

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/DataGrid.js:166:
WebInspector.DataGrid.TrivialComparator = function(a, b)
On 2014/06/30 12:36:55, alph wrote:
> Perhaps it's worth to drop this thing and just have a dummy function in the
> DirectoryContentView.

I plan to use this one for case when _sortingFunction is not assigned.

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/DataGrid.js:181: var aNumber = Number(aValue
instanceof Node ? aValue.textContent : aValue);
On 2014/06/30 12:36:55, alph wrote:
> It would be nice to have the instanceof check done once when the comparator is
> created

Unfortunately, it is not guaranteed that all cells in column are of specific
type.

Though, it sounds like a good thing to try.

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/DataGrid.js:831: this._sortingFunction =
sortingFunction;
On 2014/06/30 12:36:55, alph wrote:
> Can't see where that one is used.

This one will be used in my next patch.

[eustas, 2014-07-01 07:57:21]

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/DataGrid.js (right):

https://codereview.chromium.org/353363002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/DataGrid.js:181: var aNumber = Number(aValue
instanceof Node ? aValue.textContent : aValue);
On 2014/06/30 12:36:55, alph wrote:
> It would be nice to have the instanceof check done once when the comparator is
> created

If you try console.table(window.location) you will see that some cells are
"undefined" while other are Nodes.

[vsevik, 2014-07-02 09:10:45]

lgtm

[commit-bot: I haz the power, 2014-07-02 09:12:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/353363002/1

[commit-bot: I haz the power, 2014-07-02 13:22:15]

Change committed as 177380