Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 353293003: ES6: Add missing Set.prototype.keys function (Closed)

Created:
6 years, 5 months ago by arv (Not doing code reviews)
Modified:
6 years, 5 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ES6: Add missing Set.prototype.keys function https://people.mozilla.org/~jorendorff/es6-draft.html#sec-set.prototype.keys The value of the keys property is just the initial value of the values function. BUG=v8:3411 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/collection-iterator.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/harmony/collection-iterator.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
6 years, 5 months ago (2014-06-30 14:31:38 UTC) #1
rossberg
lgtm
6 years, 5 months ago (2014-06-30 14:34:18 UTC) #2
rossberg
6 years, 5 months ago (2014-06-30 14:37:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22099.

Powered by Google App Engine
This is Rietveld 408576698