Issue 3532004: [omnibox] Ignore empty search suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3532004: [omnibox] Ignore empty search suggestions. (Closed)

Created:
10 years, 2 months ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[omnibox] Ignore empty search suggestions. Google search may return empty suggestions for some weird input characters. We need to ignore them, to avoid breaking the omnibox. BUG=56214 TEST=(On Mac) In omnibox press option-i and wait for a while. Chrome shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61005 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61007

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/autocomplete/search_provider.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

10 years, 2 months ago (2010-09-29 23:41:42 UTC) #3

On 2010/09/29 23:07:34, shess wrote:
> LGTM.

WRT the double-commit, looks like when I patched this into my git client, it
overrode my client's link to my other change.  But AFAICT everything is going to
work out right as far as what actually is checked in.

Expand Messages | Collapse Messages