Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 353183006: Cleanup: Delete SkJSON header. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Delete SkJSON header. It seems it does not have any implementation so it is unlikely it will have any user, either internal or external. BUG=None TEST=make all R=bsalomon@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/10722184fddc15cb2eced53db4a47867ae1924c9

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -311 lines) Patch
M gyp/public_headers.gypi View 1 1 chunk +34 lines, -26 lines 0 comments Download
D include/utils/SkJSON.h View 1 chunk +0 lines, -285 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
6 years, 5 months ago (2014-06-27 23:23:07 UTC) #1
mtklein
lgtm
6 years, 5 months ago (2014-06-28 01:02:28 UTC) #2
tfarina
Brian, ping? I need your approval, this is touching a public header from include/.
6 years, 5 months ago (2014-06-30 14:26:13 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-06-30 23:48:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/353183006/1
6 years, 5 months ago (2014-06-30 23:49:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 23:49:01 UTC) #6
commit-bot: I haz the power
Failed to apply patch for gyp/public_headers.gypi: While running git apply --index -p1; error: patch failed: ...
6 years, 5 months ago (2014-06-30 23:49:02 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-06-30 23:53:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/353183006/20001
6 years, 5 months ago (2014-06-30 23:54:10 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 00:11:36 UTC) #10
Message was sent while issue was closed.
Change committed as 10722184fddc15cb2eced53db4a47867ae1924c9

Powered by Google App Engine
This is Rietveld 408576698