Issue 353183003: Update GOM unittests to pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353183003: Update GOM unittests to pass (Closed)

Created:
6 years, 5 months ago by eseidel

Modified:
6 years, 5 months ago

Reviewers:
ojan

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Update GOM unittests to pass Not sure why the tests changed from expecting '' to undefined, but I doubt it matters. Useful to be able to start from all tests passing. TBR=ojan@chromium.org BUG=389681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177134

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Tools/GardeningServer/scripts/ui_unittests.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eseidel

Committed patchset #1 manually as r177134 (presubmit successful).

6 years, 5 months ago (2014-06-27 20:55:00 UTC) #1

ojan

6 years, 5 months ago (2014-06-28 03:03:24 UTC) #2

Message was sent while issue was closed.

Whoops. I broke this test right before committing it by changing it to set the
actualUrl property instead of the actualUrl attribute. Thx for fixing.

lgtm

Expand Messages | Collapse Messages