Issue 353163005: add a second interface to the resizer to exactly match what Chrome expects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353163005: add a second interface to the resizer to exactly match what Chrome expects. (Closed)

Created:
6 years, 5 months ago by humper

Modified:
6 years, 5 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

add a second interface to the resizer to exactly match what Chrome expects. Will make the migration much cleaner BUG=skia: Committed: https://skia.googlesource.com/skia/+/d92f5b814d01c474a0fb52e32e10a997b2c9b5bf

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	src/core/SkBitmapScaler.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/core/SkBitmapScaler.cpp	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/353163005/1

6 years, 5 months ago (2014-06-29 02:58:34 UTC) #4

commit-bot: I haz the power

Change committed as d92f5b814d01c474a0fb52e32e10a997b2c9b5bf

6 years, 5 months ago (2014-06-29 03:12:48 UTC) #5

reed1

6 years, 5 months ago (2014-06-29 18:32:47 UTC) #6

Message was sent while issue was closed.

Do we really need two versions, esp. since these are private?
Is the bool-return version useful (I presume it is/was), to signify when we
can't scale? If so, why add the 2nd one that doesn't convey this clearly?

Expand Messages | Collapse Messages