Issue 353163004: Fix missing seek information when video has no start time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353163004: Fix missing seek information when video has no start time. (Closed)

Created:
6 years, 5 months ago by DaleCurtis

Modified:
6 years, 5 months ago

Reviewers:
rileya (GONE FROM CHROMIUM)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix missing seek information when video has no start time. A video stream without a start time is assumed to always have a starting time of zero. BUG=388070 TEST=new unittest. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280507

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
	M	media/filters/ffmpeg_demuxer.cc	View		3 chunks	+12 lines, -8 lines	0 comments	Download
	M	media/filters/ffmpeg_demuxer_unittest.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

DaleCurtis

One more! Pulled off of https://codereview.chromium.org/353563002/ since that looks like it might take a while ...

6 years, 5 months ago (2014-06-27 22:21:47 UTC) #1

rileya (GONE FROM CHROMIUM)

On 2014/06/27 22:21:47, DaleCurtis wrote: > One more! Pulled off of https://codereview.chromium.org/353563002/ since that > ...

6 years, 5 months ago (2014-06-27 22:32:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/353163004/1

6 years, 5 months ago (2014-06-27 22:33:32 UTC) #5

Message was sent while issue was closed.

Change committed as 280507