Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 35313002: MIPS: Ensure double aligned allocations through runtime routines.

Created:
7 years, 2 months ago by dusmil
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Ensure double aligned allocations through runtime routines. 3rd (of 3) CLs to ensure complete alignment of FixedDoubleArrays. TEST= BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/runtime.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dusmil
PTAL, if this looks OK, we can add this change to the other arch's in ...
7 years, 2 months ago (2013-10-22 16:39:16 UTC) #1
Paul Lind
LGTM, but this one also needs v8 team review, PTAL....
7 years, 1 month ago (2013-11-06 17:24:49 UTC) #2
Paul Lind
Adding Michael to reviewers.
7 years, 1 month ago (2013-11-14 16:41:45 UTC) #3
Michael Starzinger
I just uploaded another change that should it make much easier to implement this alignment ...
7 years, 1 month ago (2013-11-15 11:26:54 UTC) #4
dusmil
Thank you Michael, it is much simpler now, and code duplication has been avoided. I ...
7 years, 1 month ago (2013-11-15 15:25:34 UTC) #5
Michael Starzinger
LGTM.
7 years, 1 month ago (2013-11-15 17:45:23 UTC) #6
Paul Lind
7 years, 1 month ago (2013-11-17 17:25:21 UTC) #7
Committed as r17809.

Powered by Google App Engine
This is Rietveld 408576698