Issue 353113003: Remove dependency from platform files on v8.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353113003: Remove dependency from platform files on v8.h (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 5 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Remove dependency from platform files on v8.h Pass flag values in through a central initialize call. We still depend on utils.h for RoundUp and IsAligned. BUG=none R=bmeurer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22048

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -94 lines)			Patch
M	src/base/macros.h	View	2 chunks	+47 lines, -0 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	src/platform.h	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	src/platform-cygwin.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/platform-freebsd.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/platform-linux.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/platform-macos.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/platform-openbsd.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/platform-posix.cc	View	5 chunks	+27 lines, -5 lines	0 comments	Download
M	src/platform-qnx.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/platform-solaris.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/platform-win32.cc	View	6 chunks	+17 lines, -7 lines	0 comments	Download
M	src/v8.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

6 years, 5 months ago (2014-06-27 08:39:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22048 (presubmit successful).