Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 353113002: GN: content/content_tests.gypi support targets (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

GN: content/content_tests.gypi support targets This starts GN targets for //content/test:*support*. They aren't used anywhere yet but will be used by many unit test targets. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281716

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -166 lines) Patch
M content/common/BUILD.gn View 1 2 chunks +8 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 3 chunks +168 lines, -162 lines 0 comments Download
A content/test/BUILD.gn View 1 1 chunk +168 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
https://codereview.chromium.org/353113002/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://codereview.chromium.org/353113002/diff/1/content/common/BUILD.gn#newcode98 content/common/BUILD.gn:98: "//content:resources", i can't find this one in gyp but ...
6 years, 6 months ago (2014-06-27 06:01:15 UTC) #1
brettw
lgtm https://codereview.chromium.org/353113002/diff/1/content/content_tests.gypi File content/content_tests.gypi (right): https://codereview.chromium.org/353113002/diff/1/content/content_tests.gypi#newcode172 content/content_tests.gypi:172: # GN version: //content/test:layouttest_support I normally indent this ...
6 years, 5 months ago (2014-06-30 17:26:06 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-07-08 05:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/353113002/1
6 years, 5 months ago (2014-07-08 05:27:16 UTC) #4
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 5 months ago (2014-07-08 05:27:55 UTC) #5
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-07-08 05:41:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/353113002/20001
6 years, 5 months ago (2014-07-08 05:42:01 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 10:59:22 UTC) #8
Message was sent while issue was closed.
Change committed as 281716

Powered by Google App Engine
This is Rietveld 408576698