Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 3531019: net: remove test flakyness caused by uncorking. (Closed)

Created:
10 years, 2 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

net: remove test flakyness caused by uncorking. r61546 (reverted r61546, landed r61638, reverted r61672; it was blameless for the first revert.) caused flakyness in the SSLClientSocket tests because the SSL_CONNECT event may be hidden by a SOCKET_SENT event in the case that the test takes over 200ms to run. This patch changes the test to match against either event. BUG=none TEST=net_unittests

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M net/socket/ssl_client_socket_unittest.cc View 6 chunks +18 lines, -13 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
agl
10 years, 2 months ago (2010-10-07 19:12:55 UTC) #1
wtc
LGTM. http://codereview.chromium.org/3531019/diff/1/2 File net/socket/ssl_client_socket_unittest.cc (right): http://codereview.chromium.org/3531019/diff/1/2#newcode46 net/socket/ssl_client_socket_unittest.cc:46: const net::CapturingNetLog::EntryList& log, int i) { BUG: the ...
10 years, 2 months ago (2010-10-07 21:25:25 UTC) #2
wtc
10 years, 2 months ago (2010-10-07 21:29:54 UTC) #3
http://codereview.chromium.org/3531019/diff/1/2
File net/socket/ssl_client_socket_unittest.cc (right):

http://codereview.chromium.org/3531019/diff/1/2#newcode43
net/socket/ssl_client_socket_unittest.cc:43: // timeout. This means that an SSL
connect end event may appear as a socket
This sentence is confusing.  Can you explain exactly what
happens?  I think when the test fails, we have an
SSL connect end event, followed by a SOCKET_BYTES_SENT
event, right?  So the SSL connect end event is not missing;
it's just shadowed by the SOCKET_BYTES_SENT event caused by
the uncorking timer.

Powered by Google App Engine
This is Rietveld 408576698