Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 353083002: AnimationTimeline::serviceAnimations should reserveInitialCapacity (Closed)

Created:
6 years, 5 months ago by abarth-chromium
Modified:
6 years, 5 months ago
Reviewers:
dstockwell
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

AnimationTimeline::serviceAnimations should reserveInitialCapacity Rather than reallocating the players vector, we can just reserve exactly the correct capacity ahead of time. I didn't see these mallocs on a profile, but this code is executed every frame during composited animations. R=dstockwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/animation/AnimationTimeline.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
6 years, 5 months ago (2014-06-26 20:50:01 UTC) #1
dstockwell
lgtm
6 years, 5 months ago (2014-06-26 23:13:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/353083002/1
6 years, 5 months ago (2014-06-26 23:14:59 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 02:31:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 02:37:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/1902)
6 years, 5 months ago (2014-06-27 02:37:03 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-06-27 03:14:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/353083002/1
6 years, 5 months ago (2014-06-27 03:15:35 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 03:33:32 UTC) #9
Message was sent while issue was closed.
Change committed as 177053

Powered by Google App Engine
This is Rietveld 408576698