Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/test/chromedriver/performance_logger.h

Issue 353063005: [ChromeDriver] Subscribe PerformanceLogger to CommandListener interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unnecessary check in test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/logging_unittest.cc ('k') | chrome/test/chromedriver/performance_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/performance_logger.h
diff --git a/chrome/test/chromedriver/chrome/performance_logger.h b/chrome/test/chromedriver/performance_logger.h
similarity index 76%
rename from chrome/test/chromedriver/chrome/performance_logger.h
rename to chrome/test/chromedriver/performance_logger.h
index b9cc8a14104a633bd4ecccbe9bd78d302934f8e9..b4c8eb44d5cf9b772c5feae5ebcbbbc35d4637d5 100644
--- a/chrome/test/chromedriver/chrome/performance_logger.h
+++ b/chrome/test/chromedriver/performance_logger.h
@@ -2,12 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_TEST_CHROMEDRIVER_CHROME_PERFORMANCE_LOGGER_H_
-#define CHROME_TEST_CHROMEDRIVER_CHROME_PERFORMANCE_LOGGER_H_
+#ifndef CHROME_TEST_CHROMEDRIVER_PERFORMANCE_LOGGER_H_
+#define CHROME_TEST_CHROMEDRIVER_PERFORMANCE_LOGGER_H_
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
+#include "chrome/test/chromedriver/command_listener.h"
class Log;
@@ -18,7 +19,7 @@ class Log;
// "webview": <originating WebView ID>,
// "message": { "method": "...", "params": { ... }} // DevTools message.
// }
-class PerformanceLogger : public DevToolsEventListener {
+class PerformanceLogger : public DevToolsEventListener, public CommandListener {
public:
// Creates a PerformanceLogger that creates entries in the given Log object.
// The log is owned elsewhere and must not be null.
@@ -31,10 +32,12 @@ class PerformanceLogger : public DevToolsEventListener {
const std::string& method,
const base::DictionaryValue& params) OVERRIDE;
+ virtual Status BeforeCommand(const std::string& command_name) OVERRIDE;
+
private:
Log* log_; // The log where to create entries.
DISALLOW_COPY_AND_ASSIGN(PerformanceLogger);
};
-#endif // CHROME_TEST_CHROMEDRIVER_CHROME_PERFORMANCE_LOGGER_H_
+#endif // CHROME_TEST_CHROMEDRIVER_PERFORMANCE_LOGGER_H_
« no previous file with comments | « chrome/test/chromedriver/logging_unittest.cc ('k') | chrome/test/chromedriver/performance_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698