Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3783)

Unified Diff: chrome/test/chromedriver/logging.h

Issue 353063005: [ChromeDriver] Subscribe PerformanceLogger to CommandListener interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unnecessary check in test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging.h
diff --git a/chrome/test/chromedriver/logging.h b/chrome/test/chromedriver/logging.h
index eb2cde881ca6ac460cbb1232792848ea086b1f41..78e0aba4b083d82379bca16539c1dcdb27e80372 100644
--- a/chrome/test/chromedriver/logging.h
+++ b/chrome/test/chromedriver/logging.h
@@ -14,6 +14,7 @@
#include "chrome/test/chromedriver/chrome/log.h"
struct Capabilities;
+class CommandListener;
class DevToolsEventListener;
class ListValue;
class Status;
@@ -64,9 +65,11 @@ class WebDriverLog : public Log {
// Initializes logging system for ChromeDriver. Returns true on success.
bool InitLogging();
-// Creates Log's and DevToolsEventListener's based on logging preferences.
+// Creates |Log|s, |DevToolsEventListener|s, and |CommandListener|s based on
+// logging preferences.
Status CreateLogs(const Capabilities& capabilities,
ScopedVector<WebDriverLog>* out_logs,
- ScopedVector<DevToolsEventListener>* out_listeners);
+ ScopedVector<DevToolsEventListener>* out_devtools_listeners,
+ ScopedVector<CommandListener>* out_command_listeners);
#endif // CHROME_TEST_CHROMEDRIVER_LOGGING_H_
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698