Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8428)

Unified Diff: chrome/test/chromedriver/chrome/performance_logger.cc

Issue 353063005: [ChromeDriver] Subscribe PerformanceLogger to CommandListener interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unnecessary check in test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/performance_logger.cc
diff --git a/chrome/test/chromedriver/chrome/performance_logger.cc b/chrome/test/chromedriver/chrome/performance_logger.cc
deleted file mode 100644
index 4e51a6258411350a3e8c3bc02f2cd49f4b449341..0000000000000000000000000000000000000000
--- a/chrome/test/chromedriver/chrome/performance_logger.cc
+++ /dev/null
@@ -1,65 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/test/chromedriver/chrome/performance_logger.h"
-
-#include "base/json/json_writer.h"
-#include "base/strings/string_util.h"
-#include "base/values.h"
-#include "chrome/test/chromedriver/chrome/devtools_client.h"
-#include "chrome/test/chromedriver/chrome/log.h"
-#include "chrome/test/chromedriver/chrome/status.h"
-
-namespace {
-
-// DevTools event domain prefixes to intercept.
-const char* const kDomains[] = {"Network.", "Page.", "Timeline."};
-
-const char* const kDomainEnableCommands[] = {
- "Network.enable", "Page.enable", "Timeline.start"
-};
-
-// Returns whether the event belongs to one of kDomains.
-bool ShouldLogEvent(const std::string& method) {
- for (size_t i_domain = 0; i_domain < arraysize(kDomains); ++i_domain) {
- if (StartsWithASCII(method, kDomains[i_domain], true /* case_sensitive */))
- return true;
- }
- return false;
-}
-
-} // namespace
-
-PerformanceLogger::PerformanceLogger(Log* log)
- : log_(log) {}
-
-Status PerformanceLogger::OnConnected(DevToolsClient* client) {
- base::DictionaryValue params; // All our enable commands have empty params.
- for (size_t i_cmd = 0; i_cmd < arraysize(kDomainEnableCommands); ++i_cmd) {
- Status status = client->SendCommand(kDomainEnableCommands[i_cmd], params);
- if (status.IsError())
- return status;
- }
- return Status(kOk);
-}
-
-Status PerformanceLogger::OnEvent(
- DevToolsClient* client,
- const std::string& method,
- const base::DictionaryValue& params) {
- if (!ShouldLogEvent(method))
- return Status(kOk);
-
- base::DictionaryValue log_message_dict;
- log_message_dict.SetString("webview", client->GetId());
- log_message_dict.SetString("message.method", method);
- log_message_dict.Set("message.params", params.DeepCopy());
- std::string log_message_json;
- // TODO(klm): extract timestamp from params?
- // Look at where it is for Page, Network, Timeline events.
- base::JSONWriter::Write(&log_message_dict, &log_message_json);
-
- log_->AddEntry(Log::kInfo, log_message_json);
- return Status(kOk);
-}
« no previous file with comments | « chrome/test/chromedriver/chrome/performance_logger.h ('k') | chrome/test/chromedriver/chrome/performance_logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698