[ChromeDriver] Subscribe PerformanceLogger to CommandListener interface

chrome/test/chromedriver/session_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <list>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/test/chromedriver/chrome/status.h"
 #include "chrome/test/chromedriver/chrome/stub_chrome.h"
 #include "chrome/test/chromedriver/chrome/stub_web_view.h"
 #include "chrome/test/chromedriver/session.h"
+#include "chrome/test/chromedriver/util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 class MockChrome : public StubChrome {
  public:
   MockChrome() : web_view_("1") {}
   virtual ~MockChrome() {}
 
   virtual Status GetWebViewById(const std::string& id,
                                 WebView** web_view) OVERRIDE {
     if (id == web_view_.GetId()) {
       *web_view = &web_view_;
       return Status(kOk);
     }
     return Status(kUnknownError);
   }
 
  private:
   StubWebView web_view_;
 };
 
+class MockCommandListener : public CommandListener {

[stgao, 2014/07/01 19:02:27]

Duplicate code again.
Now it seems that it should be in a shared class as I mentioned above.

[johnmoore, 2014/07/02 22:17:45]

I have removed AddListener from session, so this duplicate code is no longer
needed.

+ public:
+  MockCommandListener() : called_(false) {}
+  virtual ~MockCommandListener() {}
+
+  virtual Status BeforeCommand(const std::string& command_name) OVERRIDE {
+    called_ = true;
+    EXPECT_STREQ("cmd", command_name.c_str());
+    return Status(kOk);
+  }
+
+  void VerifyCalled() {
+    EXPECT_TRUE(called_);
+  }
+
+  void VerifyNotCalled() {
+    EXPECT_FALSE(called_);
+  }
+
+ private:
+  bool called_;
+};
+
 }  // namespace
 
 TEST(Session, GetTargetWindowNoChrome) {
   Session session("1");
   WebView* web_view;
   ASSERT_EQ(kNoSuchWindow, session.GetTargetWindow(&web_view).code());
 }
 
 TEST(Session, GetTargetWindowTargetWindowClosed) {
   scoped_ptr<Chrome> chrome(new MockChrome());
@@ skipping 49 matching lines @@
   session.SwitchToTopFrame();
   ASSERT_EQ(std::string(), session.GetCurrentFrameId());
 
   session.SwitchToSubFrame("3.1", std::string());
   ASSERT_EQ("3.1", session.GetCurrentFrameId());
   session.SwitchToSubFrame("3.2", std::string());
   ASSERT_EQ("3.2", session.GetCurrentFrameId());
   session.SwitchToTopFrame();
   ASSERT_EQ(std::string(), session.GetCurrentFrameId());
 }
+
+TEST(Session, OnCommand) {
+  Session session("1");
+  // Listeners are owned by and will be destroyed by session
+  MockCommandListener* listener1 = new MockCommandListener();
+  MockCommandListener* listener2 = new MockCommandListener();
+  session.AddListener(listener1);
+  session.AddListener(listener2);
+  listener1->VerifyNotCalled();
+  listener2->VerifyNotCalled();
+  NotifySessionListenersBeforeCommand(&session, "cmd");
+  listener1->VerifyCalled();
+  listener2->VerifyCalled();
+}