chrome/test/chromedriver/performance_logger_unittest.cc - Issue 353063005: [ChromeDriver] Subscribe PerformanceLogger to CommandListener interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/performance_logger_unittest.cc

Issue 353063005: [ChromeDriver] Subscribe PerformanceLogger to CommandListener interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing unnecessary check in test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | chrome/test/chromedriver/session.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/test/chromedriver/chrome/performance_logger.h"	5 #include "chrome/test/chromedriver/performance_logger.h"

6	6

7 #include "base/compiler_specific.h"	7 #include "base/compiler_specific.h"

8 #include "base/format_macros.h"	8 #include "base/format_macros.h"

9 #include "base/json/json_reader.h"	9 #include "base/json/json_reader.h"

10 #include "base/memory/scoped_vector.h"	10 #include "base/memory/scoped_vector.h"

11 #include "base/time/time.h"	11 #include "base/time/time.h"

12 #include "base/values.h"	12 #include "base/values.h"

13 #include "chrome/test/chromedriver/chrome/log.h"	13 #include "chrome/test/chromedriver/chrome/log.h"

14 #include "chrome/test/chromedriver/chrome/status.h"	14 #include "chrome/test/chromedriver/chrome/status.h"

15 #include "chrome/test/chromedriver/chrome/stub_devtools_client.h"	15 #include "chrome/test/chromedriver/chrome/stub_devtools_client.h"

(...skipping 165 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
181 ExpectEnableDomains(client1);	181 ExpectEnableDomains(client1);

182 EXPECT_TRUE(client2.PopSentCommand().empty());	182 EXPECT_TRUE(client2.PopSentCommand().empty());

183	183

184 ASSERT_EQ(kOk, client1.TriggerEvent("Page.gaga1").code());	184 ASSERT_EQ(kOk, client1.TriggerEvent("Page.gaga1").code());

185 ASSERT_EQ(kOk, client2.TriggerEvent("Timeline.gaga2").code());	185 ASSERT_EQ(kOk, client2.TriggerEvent("Timeline.gaga2").code());

186	186

187 ASSERT_EQ(2u, log.GetEntries().size());	187 ASSERT_EQ(2u, log.GetEntries().size());

188 ValidateLogEntry(log.GetEntries()[0], "webview-1", "Page.gaga1");	188 ValidateLogEntry(log.GetEntries()[0], "webview-1", "Page.gaga1");

189 ValidateLogEntry(log.GetEntries()[1], "webview-2", "Timeline.gaga2");	189 ValidateLogEntry(log.GetEntries()[1], "webview-2", "Timeline.gaga2");

190 }	190 }

OLD	NEW