Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: chrome/browser/renderer_host/database_dispatcher_host.h

Issue 353015: Last patch in removing MessageLoop* caching. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/database_dispatcher_host.h
===================================================================
--- chrome/browser/renderer_host/database_dispatcher_host.h (revision 30863)
+++ chrome/browser/renderer_host/database_dispatcher_host.h (working copy)
@@ -7,7 +7,6 @@
#include "base/file_path.h"
-class MessageLoop;
class ResourceMessageFilter;
namespace IPC {
@@ -23,6 +22,8 @@
// Returns true iff the message is HTML5 DB related and was processed.
bool OnMessageReceived(const IPC::Message& message, bool* message_was_ok);
+ private:
+ // Message handlers.
// Processes the request to return a handle to the given DB file.
void OnDatabaseOpenFile(const FilePath& file_name,
int desired_flags,
@@ -41,10 +42,6 @@
void OnDatabaseGetFileSize(const FilePath& file_name,
int32 message_id);
- private:
- // Determines if the message is HTML5 DB related.
- bool IsDBMessage(const IPC::Message& message);
-
// Returns the directory where all DB files are stored.
FilePath GetDBDir();
@@ -54,11 +51,10 @@
// The user data directory.
FilePath profile_path_;
- // The ResourceMessageFilter instance of this renderer process.
+ // The ResourceMessageFilter instance of this renderer process. Can't keep
+ // a refptr or else we'll get into a cycle. It's always ok to use this in
+ // the IO thread since if the RMF goes away, this object is deleted.
ResourceMessageFilter* resource_message_filter_;
-
- // The message loop of the file thread.
- MessageLoop* file_thread_message_loop_;
};
#endif // CHROME_BROWSER_RENDERER_HOST_DATABASE_DISPATCHER_HOST_H_
« no previous file with comments | « chrome/browser/renderer_host/cross_site_resource_handler.cc ('k') | chrome/browser/renderer_host/database_dispatcher_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698