chrome/renderer/resources/extensions/web_view_deny.js - Issue 353013007: Implement <appview> skeleton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view_deny.js

Issue 353013007: Implement <appview> skeleton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Fixed PermissionsTest unit test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/web_view_deny.js

diff --git a/chrome/renderer/resources/extensions/web_view_deny.js b/chrome/renderer/resources/extensions/web_view_deny.js

index 5c86ec92f105c8f1ca8d22bf79f62206bc96bd50..a3e70f473dd505666c80bac26fe104433d296533 100644

--- a/chrome/renderer/resources/extensions/web_view_deny.js

+++ b/chrome/renderer/resources/extensions/web_view_deny.js

@@ -14,7 +14,7 @@ function registerWebViewElement() {

var proto = Object.create(HTMLElement.prototype);

proto.createdCallback = function() {

- console.error(errorMessage);

+ window.console.error(errorMessage);

};

window.WebView =

@@ -23,8 +23,8 @@ function registerWebViewElement() {

// Delete the callbacks so developers cannot call them and produce unexpected

// behavior.

delete proto.createdCallback;

- delete proto.enteredDocumentCallback;

- delete proto.leftDocumentCallback;

+ delete proto.attachedCallback;

+ delete proto.detachedCallback;

delete proto.attributeChangedCallback;

}