extensions/renderer/dispatcher.cc - Issue 353013007: Implement <appview> skeleton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.cc

Issue 353013007: Implement <appview> skeleton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_skeleton

Patch Set: Addressed comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/dispatcher.cc

diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc

index 44b2fd0f96e818a1bf056574ab16224c2ad99ab8..647f4f4f0bc572dd72432dc22ee72a5fa1bfd418 100644

--- a/extensions/renderer/dispatcher.cc

+++ b/extensions/renderer/dispatcher.cc

@@ -830,7 +830,9 @@ void Dispatcher::UpdateOriginPermissions(

void Dispatcher::EnableCustomElementWhiteList() {

blink::WebCustomElement::addEmbedderCustomElementName("webview");

- blink::WebCustomElement::addEmbedderCustomElementName("browser-plugin");

+ blink::WebCustomElement::addEmbedderCustomElementName("appview");

+ blink::WebCustomElement::addEmbedderCustomElementName("appplugin");

not at google - send to devlin 2014/06/27 17:32:19 ppp looks funny :)

Fady Samuel 2014/06/27 18:14:31 Fortunately, an internal custom element (that we u

+ blink::WebCustomElement::addEmbedderCustomElementName("browserplugin");

}

void Dispatcher::UpdateBindings(const std::string& extension_id) {