Implement <appview> skeleton.

chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"
 
 #include "base/command_line.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 217 matching lines @@
   source_map->RegisterSource("webstore", IDR_WEBSTORE_CUSTOM_BINDINGS_JS);
   source_map->RegisterSource("windowControls", IDR_WINDOW_CONTROLS_JS);
 
   // Custom types sources.
   source_map->RegisterSource("ChromeSetting", IDR_CHROME_SETTING_JS);
   source_map->RegisterSource("ContentSetting", IDR_CONTENT_SETTING_JS);
   source_map->RegisterSource("ChromeDirectSetting",
                              IDR_CHROME_DIRECT_SETTING_JS);
 
   // Platform app sources that are not API-specific..
+  source_map->RegisterSource("appView", IDR_APP_VIEW_JS);
   source_map->RegisterSource("tagWatcher", IDR_TAG_WATCHER_JS);
   source_map->RegisterSource("webViewInternal",
                              IDR_WEB_VIEW_INTERNAL_CUSTOM_BINDINGS_JS);
   // Note: webView not webview so that this doesn't interfere with the
   // chrome.webview API bindings.
   source_map->RegisterSource("webView", IDR_WEB_VIEW_JS);
   source_map->RegisterSource("webViewEvents", IDR_WEB_VIEW_EVENTS_JS);
   source_map->RegisterSource("webViewExperimental",
                              IDR_WEB_VIEW_EXPERIMENTAL_JS);
   source_map->RegisterSource("webViewRequest",
@@ skipping 39 matching lines @@
             hexencoded_id_hash == "E703483CEF33DEC18B4B6DD84B5C776FB9182BDB" ||
             hexencoded_id_hash == "1A26E32DE447A17CBE5E9750CDBA78F58539B39C" ||
             hexencoded_id_hash == "59048028102D7B4C681DBC7BC6CD980C3DC66DA3") {
           module_system->Require("webViewExperimental");
         }
       }
     } else {
       module_system->Require("denyWebView");
     }
   }
+
+  if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT) {
+    if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableAppView) &&
+        extension->permissions_data()->HasAPIPermission(
+            extensions::APIPermission::kAppView)) {
+      module_system->Require("appView");
+    }

[not at google - send to devlin, 2014/06/27 17:32:19]

questions:
- why is this different logic to webview?
- what about "denyAppView"?
and please add a big todo somewhere; eagerly calling Request on context startup
is expensive, it would be better if there were a lightweight way of detecting
when an adview (or webview) is created and only then set up the infrastructure.
don't custom elements give you a way to do that?

this comment should go at the top of RequireAdditionalModels.

[Fady Samuel, 2014/06/27 18:14:31]

1. <webview> will work in unblessed contexts in the near feature (in component
extensions on WebUI pages). No immediate plans to support this for appview.
<webview> also has experimental features that are white listed. <appview> does
not.
Good point. Added.
I'm not sure how to do that but I can investigate in a separate patch.

[not at google - send to devlin, 2014/06/27 18:16:17]

So the "unblessed" isn't needed yet? can we take that out (in a separate CL)
because there are better ways to implement this for webui.
thanks.

+  }
 }
 
 void ChromeExtensionsDispatcherDelegate::OnActiveExtensionsUpdated(
     const std::set<std::string>& extension_ids) {
   // In single-process mode, the browser process reports the active extensions.
   if (CommandLine::ForCurrentProcess()->HasSwitch(::switches::kSingleProcess))
     return;
   crash_keys::SetActiveExtensions(extension_ids);
 }
 
@@ skipping 41 matching lines @@
       new extensions::PermissionSet(extensions::APIPermissionSet(),
                                     extensions::ManifestPermissionSet(),
                                     origin_set,
                                     extensions::URLPatternSet()));
 }
 
 void ChromeExtensionsDispatcherDelegate::HandleWebRequestAPIUsage(
     bool webrequest_used) {
   webrequest_used_ = webrequest_used;
 }