Simplify (and optimize) SVGTextQuery::characterNumberAtPositionCallback

Simplify (and optimize) SVGTextQuery::characterNumberAtPositionCallback

This method needs to iterate the glyphs within a fragment and check if the
queried point is contained within any of them.
Currently a fragment offset is converted to a offset that's suitable for
passing to mapStartEndPositionsIntoFragmentCoordinates - which then in
turn maps it into a text box-relative offset and then runs (the costly)
modifyStartEndPositionsRespectingLigatures to check if the current range
happen to fall within a "multicharacter glyph" (ligatures etc.), and then
expand the range appropriately.
This is a lot of work, that is better performed by finding the index within
the text metrics list for the corresponding RenderSVGInlineText object,
and then step through the fragment using the lengths of the individual
glyphs.
The impact on performance will vary with the length of fragments and the
length of the text content.
For a case like:

  <text ...>(AAAAAAAAAA ){99}AAAAAAAAAA</text>

  (100 groups of ten A's separated by a single whitespace)

with a negative query, the speed-up is ~1.2x. With 'word-spacing' added
(to get more fragments) the speed-up becomes ~8.7x.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177089

[fs, 2014-06-26 16:25:11]

This is the cleanup CL mentioned in some other CL touching this code. Hopefully
this makes it slightly less tricky...

(Win-builders seem a bit busted ATM.)

[pdr., 2014-06-26 17:42:50]

On 2014/06/26 16:25:11, fs wrote:
> This is the cleanup CL mentioned in some other CL touching this code.
Hopefully
> this makes it slightly less tricky...
> 
> (Win-builders seem a bit busted ATM.)

Nice cleanup!

LGTM

[fs, 2014-06-27 09:17:44]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-06-27 09:18:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fs@opera.com/353003002/1

[commit-bot: I haz the power, 2014-06-27 10:25:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14043)

[commit-bot: I haz the power, 2014-06-27 11:04:03]

Change committed as 177089