Source/devtools/front_end/sdk/Target.js - Issue 352953002: DevTools: properly support targets in LiveEditSupport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/Target.js

Issue 352953002: DevTools: properly support targets in LiveEditSupport (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/sdk/ResourceScriptMapping.js ('k') | Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sdk/Target.js

diff --git a/Source/devtools/front_end/sdk/Target.js b/Source/devtools/front_end/sdk/Target.js

index 44b3a074831f2b64cfc713efd5ecb3584c7d73a1..3c62942fef2031359ec55a96a9cb59e4a1d8c5e7 100644

--- a/Source/devtools/front_end/sdk/Target.js

+++ b/Source/devtools/front_end/sdk/Target.js

@@ -146,7 +146,8 @@ WebInspector.Target.prototype = {

if (!WebInspector.cpuProfilerModel)

WebInspector.cpuProfilerModel = this.cpuProfilerModel;

- this._debuggerScriptMapping = new WebInspector.DebuggerScriptMapping(this.debuggerModel, WebInspector.workspace, WebInspector.networkWorkspaceBinding);

+ /** @type {!WebInspector.DebuggerScriptMapping} */

+ this.debuggerScriptMapping = new WebInspector.DebuggerScriptMapping(this.debuggerModel, WebInspector.workspace, WebInspector.networkWorkspaceBinding);

if (callback)

callback(this);

@@ -183,7 +184,7 @@ WebInspector.Target.prototype = {

{

this.debuggerModel.dispose();

this.networkManager.dispose();

- this._debuggerScriptMapping.dispose();

+ this.debuggerScriptMapping.dispose();

__proto__: Protocol.Agents.prototype