Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3109)

Unified Diff: chrome/browser/history/history_service.cc

Issue 352913002: Port HistoryService::ScheduleDBTask to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix lifetime of base::CancelableTaskTracker for HistoryModelWorker Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index cb4d16040149ac4635d1710007f80d001182b822..74b9c1fdb5fb9ff6929a63cea1f48717ff006283 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -378,13 +378,21 @@ void HistoryService::URLsNoLongerBookmarked(const std::set<GURL>& urls) {
urls);
}
-void HistoryService::ScheduleDBTask(history::HistoryDBTask* task,
- CancelableRequestConsumerBase* consumer) {
- DCHECK(thread_checker_.CalledOnValidThread());
- history::HistoryDBTaskRequest* request = new history::HistoryDBTaskRequest(
- base::Bind(&history::HistoryDBTask::DoneRunOnMainThread, task));
- request->value = task; // The value is the task to execute.
- Schedule(PRIORITY_UI, &HistoryBackend::ProcessDBTask, consumer, request);
+void HistoryService::ScheduleDBTask(scoped_refptr<history::HistoryDBTask> task,
+ base::CancelableTaskTracker* tracker) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ base::CancelableTaskTracker::IsCanceledCallback is_canceled;
+ tracker->NewTrackedTaskId(&is_canceled);
+ // Use base::ThreadTaskRunnerHandler::Get() to get a message loop proxy to
+ // the current message loop so that we can forward the call to the method
+ // HistoryDBTask::DoneRunOnMainThread in the correct thread.
+ thread_->message_loop_proxy()->PostTask(
+ FROM_HERE,
+ base::Bind(&HistoryBackend::ProcessDBTask,
+ history_backend_.get(),
+ task,
+ base::ThreadTaskRunnerHandle::Get(),
+ is_canceled));
}
void HistoryService::FlushForTest(const base::Closure& flushed) {
« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698