chrome/browser/history/history_browsertest.cc - Issue 352913002: Port HistoryService::ScheduleDBTask to CancelableTaskTracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_browsertest.cc

Issue 352913002: Port HistoryService::ScheduleDBTask to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix lifetime of base::CancelableTaskTracker for HistoryModelWorker Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_browsertest.cc

diff --git a/chrome/browser/history/history_browsertest.cc b/chrome/browser/history/history_browsertest.cc

index 507ec291ba6cb68122ee0820f6fef12f50eafa8f..49e813cc922f2001238e9d907b5b498c1842c1cb 100644

--- a/chrome/browser/history/history_browsertest.cc

+++ b/chrome/browser/history/history_browsertest.cc

@@ -86,12 +86,12 @@ class HistoryBrowserTest : public InProcessBrowserTest {

}

void WaitForHistoryBackendToRun() {

- CancelableRequestConsumerTSimple<int> request_consumer;

+ base::CancelableTaskTracker task_tracker;

scoped_refptr<history::HistoryDBTask> task(new WaitForHistoryTask());

HistoryService* history =

HistoryServiceFactory::GetForProfile(GetProfile(),

Profile::EXPLICIT_ACCESS);

- history->HistoryService::ScheduleDBTask(task.get(), &request_consumer);

+ history->HistoryService::ScheduleDBTask(task.get(), &task_tracker);

content::RunMessageLoop();

}