Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/browser/history/history_backend.h

Issue 352913002: Port HistoryService::ScheduleDBTask to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix lifetime of base::CancelableTaskTracker for HistoryModelWorker Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/delete_directive_handler.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index 6adb955f37b7575990b271de1402f9fd0094b05d..9e24f06c8226ca75f856db89e23731e07486e305 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -15,6 +15,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/memory_pressure_listener.h"
#include "base/memory/scoped_ptr.h"
+#include "base/task/cancelable_task_tracker.h"
#include "chrome/browser/history/expire_history_backend.h"
#include "chrome/browser/history/history_database.h"
#include "chrome/browser/history/history_marshaling.h"
@@ -46,6 +47,24 @@ static const size_t kMaxFaviconsPerPage = 8;
// the thumbnail database.
static const size_t kMaxFaviconBitmapsPerIconURL = 8;
+class QueuedHistoryDBTask {
+ public:
+ QueuedHistoryDBTask(
+ scoped_refptr<HistoryDBTask> task,
+ scoped_refptr<base::SingleThreadTaskRunner> origin_loop,
+ const base::CancelableTaskTracker::IsCanceledCallback& is_canceled);
+ ~QueuedHistoryDBTask();
+
+ bool is_canceled();
+ bool RunOnDBThread(HistoryBackend* backend, HistoryDatabase* db);
+ void DoneRunOnMainThread();
+
+ private:
+ scoped_refptr<HistoryDBTask> task_;
+ scoped_refptr<base::SingleThreadTaskRunner> origin_loop_;
+ base::CancelableTaskTracker::IsCanceledCallback is_canceled_;
+};
+
// *See the .cc file for more information on the design.*
//
// Internal history implementation which does most of the work of the history
@@ -320,7 +339,10 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// Generic operations --------------------------------------------------------
- void ProcessDBTask(scoped_refptr<HistoryDBTaskRequest> request);
+ void ProcessDBTask(
+ scoped_refptr<HistoryDBTask> task,
+ scoped_refptr<base::SingleThreadTaskRunner> origin_loop,
+ const base::CancelableTaskTracker::IsCanceledCallback& is_canceled);
virtual bool GetAllTypedURLs(URLRows* urls);
@@ -712,9 +734,6 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// to be invoked again if there are more tasks that need to run.
void ProcessDBTaskImpl();
- // Release all tasks in history_db_tasks_ and clears it.
- void ReleaseDBTasks();
-
virtual void BroadcastNotifications(
int type,
scoped_ptr<HistoryDetails> details) OVERRIDE;
@@ -808,9 +827,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// data.
bool segment_queried_;
- // HistoryDBTasks to run. Be sure to AddRef when adding, and Release when
- // done.
- std::list<HistoryDBTaskRequest*> db_task_requests_;
+ // List of QueuedHistoryDBTasks to run;
+ std::list<QueuedHistoryDBTask> queued_history_db_tasks_;
// Used to determine if a URL is bookmarked; may be NULL.
//
« no previous file with comments | « chrome/browser/history/delete_directive_handler.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698