Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/history/history_service.cc

Issue 352913002: Port HistoryService::ScheduleDBTask to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index a0670d7eb4fde591993ffab10e5df372fe0468a6..afc5832a019e7fa685f7787f3f933b8a89741ee6 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -376,13 +376,18 @@ void HistoryService::URLsNoLongerBookmarked(const std::set<GURL>& urls) {
urls);
}
-void HistoryService::ScheduleDBTask(history::HistoryDBTask* task,
- CancelableRequestConsumerBase* consumer) {
+void HistoryService::ScheduleDBTask(scoped_refptr<history::HistoryDBTask> task,
+ base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- history::HistoryDBTaskRequest* request = new history::HistoryDBTaskRequest(
- base::Bind(&history::HistoryDBTask::DoneRunOnMainThread, task));
- request->value = task; // The value is the task to execute.
- Schedule(PRIORITY_UI, &HistoryBackend::ProcessDBTask, consumer, request);
+ base::CancelableTaskTracker::IsCanceledCallback is_canceled;
+ tracker->NewTrackedTaskId(&is_canceled);
+ thread_->message_loop_proxy()->PostTask(
+ FROM_HERE,
+ base::Bind(&HistoryBackend::ProcessDBTask,
+ history_backend_.get(),
+ task,
+ base::ThreadTaskRunnerHandle::Get(),
blundell 2014/06/26 09:55:39 Could you explain this parameter?
sdefresne 2014/06/28 08:14:26 Done.
+ is_canceled));
}
void HistoryService::FlushForTest(const base::Closure& flushed) {

Powered by Google App Engine
This is Rietveld 408576698