Issue 352903002: Simplify InlineFlowBox::paintBoxDecorations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 352903002: Simplify InlineFlowBox::paintBoxDecorations. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 5 months ago

Reviewers:
leviw_travelin_and_unemployed, eae, Julien - ping for review

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplify InlineFlowBox::paintBoxDecorations. This change: * simplifies the paintPhase checks in InlineFlowBox::paint * clarifies and moves the "should paint box decorations" check above other work, including the roundedFrameRect computation * makes some internal painting methods private * fixes the name of "adjustedPaintOffset" * resolves lint errors that arose during the above 3% reduction in record time on desktop Wikipedia. Negligible impact on N7 key_silk_cases. BUG=388946 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177180

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -103 lines)			Patch
	M	Source/core/rendering/InlineFlowBox.h	View		2 chunks	+6 lines, -5 lines	0 comments	Download
	M	Source/core/rendering/InlineFlowBox.cpp	View		2 chunks	+97 lines, -98 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/352903002/1

6 years, 5 months ago (2014-06-30 02:06:14 UTC) #3

Message was sent while issue was closed.

Change committed as 177180

Expand Messages | Collapse Messages