Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 352833003: app_bluetooth.html: Add documentation on chrome.bluetoothLowEnergy (Closed)

Created:
6 years, 5 months ago by armansito
Modified:
6 years, 5 months ago
Reviewers:
keybuk, mkearney1, rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

app_bluetooth.html: Add documentation on chrome.bluetoothLowEnergy This CL adds a section to app_bluetooth.html with documentation on how the chrome.bluetoothLowEnergy API should be used. BUG=382625 R=keybuk@chromium.org TBR=mkearney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284778

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by keybuk@. #

Patch Set 3 : Simple rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/articles/app_bluetooth.html View 1 1 chunk +420 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
armansito
Added API documentation for bluetoothLowEnergy. Please review for correctness and clarity.
6 years, 5 months ago (2014-06-30 22:01:52 UTC) #1
keybuk
https://codereview.chromium.org/352833003/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html File chrome/common/extensions/docs/templates/articles/app_bluetooth.html (right): https://codereview.chromium.org/352833003/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html#newcode516 chrome/common/extensions/docs/templates/articles/app_bluetooth.html:516: connect to, and interact with Bluetooth Low Energy peripherals. ...
6 years, 5 months ago (2014-07-14 20:02:26 UTC) #2
armansito
https://codereview.chromium.org/352833003/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html File chrome/common/extensions/docs/templates/articles/app_bluetooth.html (right): https://codereview.chromium.org/352833003/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html#newcode516 chrome/common/extensions/docs/templates/articles/app_bluetooth.html:516: connect to, and interact with Bluetooth Low Energy peripherals. ...
6 years, 5 months ago (2014-07-19 05:22:56 UTC) #3
keybuk
lgtm please just TBR this for megan, and get this committed so the public docs ...
6 years, 5 months ago (2014-07-22 17:53:34 UTC) #4
armansito
6 years, 5 months ago (2014-07-22 21:24:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r284778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698