Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: src/objects.h

Issue 352813002: Wrap InitializeProperty around SetOwnPropertyIgnoreAttributes and switch over uses (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assert-scope.h" 9 #include "src/assert-scope.h"
10 #include "src/builtins.h" 10 #include "src/builtins.h"
(...skipping 2134 matching lines...) Expand 10 before | Expand all | Expand 10 after
2145 Handle<JSObject> object, 2145 Handle<JSObject> object,
2146 Handle<Name> key, 2146 Handle<Name> key,
2147 Handle<Object> value, 2147 Handle<Object> value,
2148 PropertyAttributes attributes, 2148 PropertyAttributes attributes,
2149 ValueType value_type = OPTIMAL_REPRESENTATION, 2149 ValueType value_type = OPTIMAL_REPRESENTATION,
2150 StoreMode mode = ALLOW_AS_CONSTANT, 2150 StoreMode mode = ALLOW_AS_CONSTANT,
2151 ExtensibilityCheck extensibility_check = PERFORM_EXTENSIBILITY_CHECK, 2151 ExtensibilityCheck extensibility_check = PERFORM_EXTENSIBILITY_CHECK,
2152 StoreFromKeyed store_mode = MAY_BE_STORE_FROM_KEYED, 2152 StoreFromKeyed store_mode = MAY_BE_STORE_FROM_KEYED,
2153 ExecutableAccessorInfoHandling handling = DEFAULT_HANDLING); 2153 ExecutableAccessorInfoHandling handling = DEFAULT_HANDLING);
2154 2154
2155 static void InitializeProperty(Handle<JSObject> object,
rossberg 2014/06/27 10:51:02 As discussed offline, it'd be nicer to call this A
Toon Verwaest 2014/06/30 11:39:38 Done.
2156 Handle<Name> key,
2157 Handle<Object> value,
2158 PropertyAttributes attributes,
2159 ValueType value_type = OPTIMAL_REPRESENTATION,
2160 StoreMode mode = ALLOW_AS_CONSTANT);
2161
2155 // Extend the receiver with a single fast property appeared first in the 2162 // Extend the receiver with a single fast property appeared first in the
2156 // passed map. This also extends the property backing store if necessary. 2163 // passed map. This also extends the property backing store if necessary.
2157 static void AllocateStorageForMap(Handle<JSObject> object, Handle<Map> map); 2164 static void AllocateStorageForMap(Handle<JSObject> object, Handle<Map> map);
2158 2165
2159 // Migrates the given object to a map whose field representations are the 2166 // Migrates the given object to a map whose field representations are the
2160 // lowest upper bound of all known representations for that field. 2167 // lowest upper bound of all known representations for that field.
2161 static void MigrateInstance(Handle<JSObject> instance); 2168 static void MigrateInstance(Handle<JSObject> instance);
2162 2169
2163 // Migrates the given object only if the target map is already available, 2170 // Migrates the given object only if the target map is already available,
2164 // or returns false if such a map is not yet available. 2171 // or returns false if such a map is not yet available.
(...skipping 8982 matching lines...) Expand 10 before | Expand all | Expand 10 after
11147 } else { 11154 } else {
11148 value &= ~(1 << bit_position); 11155 value &= ~(1 << bit_position);
11149 } 11156 }
11150 return value; 11157 return value;
11151 } 11158 }
11152 }; 11159 };
11153 11160
11154 } } // namespace v8::internal 11161 } } // namespace v8::internal
11155 11162
11156 #endif // V8_OBJECTS_H_ 11163 #endif // V8_OBJECTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698