Wrap InitializeProperty around SetOwnPropertyIgnoreAttributes and switch over uses

Wrap InitializeProperty around SetOwnPropertyIgnoreAttributes and switch over uses

This is a step in the direction of disentangling all uses of SetOwnPropertyIgnoreAttributes so we can provide a more specific implementation for those usecases, and reduce the capabilities of those clients, avoiding subtle bugs.

InitializeProperty only supports adding properties to extensible objects that do not contain the property yet. JSGlobalProxies cannot have properties themselves, so are not supported either.

BUG=
R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22095

[Toon Verwaest, 2014-06-25 11:52:04]

PTAL

[rossberg, 2014-06-27 10:51:02]

https://codereview.chromium.org/352813002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/352813002/diff/1/src/bootstrapper.cc#oldcode1266
src/bootstrapper.cc:1266: JSObject::SetOwnPropertyIgnoreAttributes(
Hm, why can this call just be dropped?

https://codereview.chromium.org/352813002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/352813002/diff/1/src/objects.h#newcode2155
src/objects.h:2155: static void InitializeProperty(Handle<JSObject> object,
As discussed offline, it'd be nicer to call this AddProperty

https://codereview.chromium.org/352813002/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/352813002/diff/1/src/runtime.cc#newcode8132
src/runtime.cc:8132: JSObject::SetOwnPropertyIgnoreAttributes(
Why can't InitProperty be used here?

[Toon Verwaest, 2014-06-30 11:39:39]

Addressed comments and rebased. PTAL again.

https://codereview.chromium.org/352813002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/352813002/diff/1/src/bootstrapper.cc#oldcode1266
src/bootstrapper.cc:1266: JSObject::SetOwnPropertyIgnoreAttributes(
On 2014/06/27 10:51:02, rossberg wrote:
> Hm, why can this call just be dropped?

Because NewJSObjectFromMap properly initializes all pre-allocated fields to
undefined, independent of inobject-slack-tracking. The map is marked to have 1
pre-allocate property field, which is "length".

Added an ASSERT though that it actually contains undefined_value.

https://codereview.chromium.org/352813002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/352813002/diff/1/src/objects.h#newcode2155
src/objects.h:2155: static void InitializeProperty(Handle<JSObject> object,
On 2014/06/27 10:51:02, rossberg wrote:
> As discussed offline, it'd be nicer to call this AddProperty

Done.

https://codereview.chromium.org/352813002/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/352813002/diff/1/src/runtime.cc#newcode8132
src/runtime.cc:8132: JSObject::SetOwnPropertyIgnoreAttributes(
Because "length" is already declared on the bound_function_map. This is actually
an InitializeProperty use.

On 2014/06/27 10:51:02, rossberg wrote:
> Why can't InitProperty be used here?

[rossberg, 2014-06-30 12:19:49]

lgtm

[Toon Verwaest, 2014-06-30 13:49:16]

Committed patchset #2 manually as r22095 (presubmit successful).